Repository navigation
fix(version): compare D[D]MonYYYY versions by date - #39
Merged
Merged
Conversation
LAMMPS names releases by date, 29Aug2024 or 22Jul2025_update4. cmp_version tokenized those left to right, so the day of the month decided first: 29Aug2024 sorted after 22Jul2025_update4, and 22Jul2025_update4 sorted before 22Jul2025 because a letter sorts before a number. stack gap then named LAMMPS-29Aug2024-foss-2023b-kokkos.eb as the newest recipe outside generation 2026.1, though EasyBuild 5.4.2 has 22Jul2025_update4. parse_version_parts now reads a leading D[D]MonYYYY date as year, month, and day, and an `update` right after it as its number, so the seven LAMMPS versions in easybuild-easyconfigs sort by release and stable update. LAMMPS is the only package there with such versions. Every other version tokenizes as before. On the EESSI 2026.06 site list from the deck demo, the stack gap output changes only in the LAMMPS row, which now names LAMMPS-22Jul2025_update4-foss-2025a-kokkos.eb. Unit tests in version.rs and gap.rs cover the order, a requirement, and the gap row; both fail without the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
D[D]MonYYYYversions compare by date, so LAMMPS22Jul2025_update4ranks after29Aug2024.cmp_versiontokenized those left to right, so the day of the month decided first:29Aug2024sorted after22Jul2025_update4, and22Jul2025_update4sorted before22Jul2025.stack gapthen namedLAMMPS-29Aug2024-foss-2023b-kokkos.ebas the newest recipe outside generation 2026.1, though EasyBuild 5.4.2 has22Jul2025_update4.parse_version_partsnow reads a leadingD[D]MonYYYYdate as year, month and day, and anupdateright after it as its number. Requirements such as>=29Aug2024compare the same way. LAMMPS is the only package in easybuild-easyconfigs with such versions. Every other version tokenizes as before.the_newest_date_version_elsewhere_is_the_latest_releaseanddate_versions_order_by_release_date_then_updatecover those. This branch andfix/gap-bump-sourceboth add tests at the same spot insrc/gap.rs; keep both. Merged with the other thirteen in this batch, the suite is 1940 passed, 0 failed, 10 ignored (1912 on main). The commit has a towncrier fragment. Main has no towncrier yet; #26 (fix/towncrier) adds it.